Skip to content

macfuse: add fs_link variant #28398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 18, 2025
Merged

macfuse: add fs_link variant #28398

merged 1 commit into from
May 18, 2025

Conversation

i0ntempest
Copy link
Member

Description

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS x.y
Xcode x.y / Command Line Tools x.y.z

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL in commit message?
  • checked your Portfile with port lint?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

@macportsbot
Copy link

Notifying maintainers:
@ra1nb0w for port macfuse.
@mohd-akram for port macfuse.

@macportsbot macportsbot added type: enhancement maintainer: open Affects an openmaintainer port by: member Created by a member with commit rights labels May 11, 2025
@i0ntempest
Copy link
Member Author

I can also put this into a variant if we don't want to violate mtree by default.

@mohd-akram
Copy link
Member

A user might have installed macFUSE from their website. We don't want to mess with that. It's this way on purpose.

@mohd-akram
Copy link
Member

I can also put this into a variant if we don't want to violate mtree by default.

This step needs to only be done once and never again. I don't think we need a variant for it.

@i0ntempest
Copy link
Member Author

I can also put this into a variant if we don't want to violate mtree by default.

This step needs to only be done once and never again. I don't think we need a variant for it.

All files being handled my MacPorts would eliminate the possibility of a broken symlink if the user removes the port. Also better user experience.
Just my 2 cent tho, I'm not going to force it if you think it's really unnecessary.

@i0ntempest i0ntempest force-pushed the fuse branch 2 times, most recently from acd1276 to 4254609 Compare May 12, 2025 10:43
@i0ntempest i0ntempest changed the title macfuse: install symlink automatically macfuse: add fs_link variant May 13, 2025
@i0ntempest i0ntempest force-pushed the fuse branch 2 times, most recently from 4062e24 to 12404d5 Compare May 13, 2025 17:17
@i0ntempest i0ntempest changed the title macfuse: add fs_link variant macfuse: add fs_link variant, delete more unwanted files May 13, 2025
@i0ntempest
Copy link
Member Author

@mohd-akram I added a few clean up steps in destroot to remove more unneeded files. Are you okay with the changes here?
Users will not need to do anything unless they choose to opt in this variant. Also I've added the same fs_link variant to a few other fuse filesystems.

@i0ntempest i0ntempest force-pushed the fuse branch 3 times, most recently from ca7c7a3 to d9c5895 Compare May 18, 2025 08:24
@mohd-akram mohd-akram changed the title macfuse: add fs_link variant, delete more unwanted files macfuse: add fs_link variant May 18, 2025
Copy link
Member

@mohd-akram mohd-akram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mohd-akram mohd-akram merged commit 2ba5fc5 into macports:master May 18, 2025
3 checks passed
@i0ntempest i0ntempest deleted the fuse branch May 18, 2025 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
by: member Created by a member with commit rights maintainer: open Affects an openmaintainer port type: enhancement
Development

Successfully merging this pull request may close these issues.

4 participants